Skip to content

Tag published version and run check-types if declared.#2

Merged
pkaminski merged 1 commit into
masterfrom
tag-version
May 18, 2026
Merged

Tag published version and run check-types if declared.#2
pkaminski merged 1 commit into
masterfrom
tag-version

Conversation

@pkaminski
Copy link
Copy Markdown
Member

@pkaminski pkaminski commented May 15, 2026

This will also require switching to write permissions in all callers; I'll commit those changes directly.


This change is Reviewable

This will also require switching to write permissions in all callers;
I'll commit those changes directly.
@pkaminski pkaminski requested a review from snoack May 15, 2026 22:53
Copy link
Copy Markdown
Contributor

@snoack snoack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snoack reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pkaminski).


.github/workflows/publish.yaml line 184 at r1 (raw file):

          const name = pkg.name;
          const version = pkg.version;
          fs.appendFileSync(process.env.GITHUB_OUTPUT, `package_name=${name}\n`);

Does the package name even matter? In practice it's just the name of the repo, and therefore redundant in the commit message, or am I missing something?

Copy link
Copy Markdown
Member Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkaminski made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on snoack).


.github/workflows/publish.yaml line 184 at r1 (raw file):

Previously, snoack (Sebastian Noack) wrote…

Does the package name even matter? In practice it's just the name of the repo, and therefore redundant in the commit message, or am I missing something?

Doesn't terribly matter, but Codex decided to give the tags' messages the full name@version treatment (see next to last line), and given that it's just a couple extra lines here I find it hard to get upset about it.

Copy link
Copy Markdown
Contributor

@snoack snoack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snoack made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pkaminski).


.github/workflows/publish.yaml line 184 at r1 (raw file):

Previously, pkaminski (Piotr Kaminski) wrote…

Doesn't terribly matter, but Codex decided to give the tags' messages the full name@version treatment (see next to last line), and given that it's just a couple extra lines here I find it hard to get upset about it.

I'm more concerned about the verbosity of the commit messages than about the workflow complexity. Mentioning the name of the project in commit messages seems quite redundant to me. Anyway, if you disagree, just mark this discussion as resolved, and merge.

Copy link
Copy Markdown
Member Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkaminski made 1 comment and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pkaminski).


.github/workflows/publish.yaml line 184 at r1 (raw file):

Previously, snoack (Sebastian Noack) wrote…

I'm more concerned about the verbosity of the commit messages than about the workflow complexity. Mentioning the name of the project in commit messages seems quite redundant to me. Anyway, if you disagree, just mark this discussion as resolved, and merge.

These are annotated tags and IIUC only the tag name (just the package version) shows in all contexts unless you explicitly do git show 1.2.3, which shows the full details including the message. Thus the length of the message should be pretty much irrelevant unless I'm missing something.

@pkaminski pkaminski merged commit a88e8d9 into master May 18, 2026
3 checks passed
@pkaminski pkaminski deleted the tag-version branch May 18, 2026 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants